The FeatureStore class has a version function which returns the Python SDK version. This gives the illusion that it is needed in the class, but it is never actually used. When I first saw it, I was confused why the class would have a version (which is why I dug into the source code). I propose simplifying the FeatureStore class by dropping the FeatureStore.version function.
The benefit will be making the code easier to understand, with less opportunity for error.
Expected Behavior
I expect the FeatureStore class not to have a version function, as it is not used and not needed.
Even if it were needed, the better way to get the version would be either directly through the function it calls (version.get_version -- also part of the SDK), or by calling feast.__version__.
The
FeatureStoreclass has aversionfunction which returns the Python SDK version. This gives the illusion that it is needed in the class, but it is never actually used. When I first saw it, I was confused why the class would have a version (which is why I dug into the source code). I propose simplifying the FeatureStore class by dropping theFeatureStore.versionfunction.The benefit will be making the code easier to understand, with less opportunity for error.
Expected Behavior
I expect the FeatureStore class not to have a version function, as it is not used and not needed.
Even if it were needed, the better way to get the version would be either directly through the function it calls (
version.get_version-- also part of the SDK), or by callingfeast.__version__.Current Behavior
The
FeatureStoreclass defines aversionfunction that is never used. https://github.com/feast-dev/feast/blob/e9cd3733f041da99bb1e84843ffe5af697085c34/sdk/python/feast/feature_store.py#L174Steps to reproduce
Specifications