feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.62k stars 1k forks source link

feat: Object store persistence in operator #4758

Closed dmartinol closed 6 days ago

dmartinol commented 1 week ago

What this PR does / why we need it:

This PR adds object store persistence configuration options to the FeatureStore CRD.

apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
  name: sample-s3-registry
spec:
  feastProject: my_project
  services:
    onlineStore:
      persistence:
        file:
          path: /data/online_store.db
    offlineStore:
      persistence:
        file:
          type: dask
    registry:
      local:
        persistence:
          file:
            path: s3://bucket/registry.db
            s3_additional_kwargs:
              ServerSideEncryption: AES256
              ACL: bucket-owner-full-control
              CacheControl: max-age=3600

Which issue(s) this PR fixes:

Relates to https://github.com/feast-dev/feast/issues/4561

dmartinol commented 1 week ago

@tchughesiv @redhatHameed FYI