search

feast-dev / feast

The Open Source Feature Store for Machine Learning
https://feast.dev
Apache License 2.0
5.62k stars 1k forks source link

chore: Upgrade react-router-dom and use-query-params to latest in /ui #4764

Open peruukki opened 5 days ago

peruukki commented 5 days ago

What this PR does / why we need it:

Upgrades react-router-dom and use-query-params to their latest versions; the latter is upgraded because its older version didn't work properly with the latest react-router-dom.

One small change in EuiCustomLink is done to avoid the error reported in #3794, I tried clicking everywhere in the UI and didn't see the error after the change.

Which issue(s) this PR fixes:

This allows to use the latest react-router-dom in a consuming app in case someone is using it, no longer being restricted to <6.4.0 due to #3794.

Misc

After the upgrade, react-router-dom writes a warning console message like this:

⚠️ React Router Future Flag Warning: Relative route resolution within Splat routes is changing in v7. You can use the v7_relativeSplatPath future flag to opt-in early. For more information, see https://reactrouter.com/v6/upgrading/future#v7_relativesplatpath.

I tried enabling the flag but it caused issues with our current custom tab routes, and I couldn't sort it out with reasonable effort at this point. Also, since the feature can require non-trivial changes, enabling it might break something in consuming apps that use react-router-dom, so maybe better to leave it later anyway.

I enabled another future flag that I saw a similar console warning about, v7_startTransition, since that seems much safer, though I did need to add one await in the tests after that.

peruukki commented 2 days ago

Do we need a label from someone to run the last check, build-docker-image-java (feature-server-java)?