Open tmihalac opened 2 days ago
@tmihalac the issue you are referring to is already closed. @tchughesiv should we create a new one or reopen it?
In the description, the postgres
type is not supported by registry
, pls change it to sql
(and also add a sql
key to the secret name)
registry:
local:
persistence:
store:
type: postgres
@tmihalac @dmartinol we should be opening new issues for operator PRs
@tmihalac please open a new gh issue for this PR
@tmihalac should your descrip example be fixed? i'd imagine it will look like this? with the secretKeyName
pulled back to under store?
kind: FeatureStore
metadata:
name: sample-s3-registry
spec:
feastProject: my_project
services:
onlineStore:
persistence:
store:
type: postgres
secretRef:
name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified
secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
@tmihalac should your descrip example be fixed? i'd imagine it will look like this? with the
secretKeyName
pulled back to under store?kind: FeatureStore metadata: name: sample-s3-registry spec: feastProject: my_project services: onlineStore: persistence: store: type: postgres secretRef: name: _SECRET_NAME_ # Secret keys should be placed as-is under the `type` (e.g postgres) key or under the secretKeyName if specified secretKeyName: my-postgres # The secret key the db parameters are in (optional parameter)
You are right fixing it now
Done
What this PR does / why we need it:
This PR adds db stores persistence configuration options to the FeatureStore CRD. DB store para
Which issue(s) this PR fixes:
Relates to https://github.com/feast-dev/feast/issues/4783