featbit / featbit-charts

Helm Charts for FeatBit
MIT License
6 stars 4 forks source link

fix issue when installing pro version with external clickhouse and kafka #9

Closed wss-rbrennan closed 1 year ago

wss-rbrennan commented 1 year ago

Encountered the following error when deploying with external clickhouse

clickhouse:
  enabled: false
Error: INSTALLATION FAILED: YAML parse error on featbit/templates/da-server-deployment.yaml: error converting YAML to JSON: yaml: line 151: mapping values are not allowed in this context

to verify add/change the following in examples/featbitpro.yaml

clickhouse:
  enabled: false

externalClickhouse:
  ## Hostname or ip address of external clickhouse
  ##
  host: "clickhouse.featbit.svc.cluster.local"
  tcpPort: 9000
  httpPort: 8123
  username: default
  password: "featbit"
  database: default
  singleNode: false  

using the main branch run helm install featbit ./ -f .\examples\featbit-pro.yaml --dry-run --debug -n featbit

Observe the error

Switch to this PR using the same values from above in featbitpro.yaml and run the helm install again, observe that the chart manifests are created.

This was due to some issues with if statements in _pro-env.tpl. while investigating this issue it was also discovered that featbit.clickhouse.secretPasswordKey in _helpers.tpl was evaluating redis settings instead of clickhouse settings, this has been corrected.