featdd / dpn_glossary

Glossary extension for TYPO3
http://typo3.org/extensions/repository/view/dpn_glossary
GNU General Public License v2.0
20 stars 30 forks source link

Umlauts upper and lower case is not distinguished correctly #189

Closed Daniel-Siteway closed 1 year ago

Daniel-Siteway commented 1 year ago

As soon as umlauts appear in the first position of the term, they are not recognized correctly by the pharser and accordingly the word is not linked.

In my case:

If the term "Öffentlicher Dienst" is entered, it is recognized in the frontend only with a capital Ö. In this case, "öffentlicher Dienst" is not recognized and case sensitivity is also disabled in the term.

If I now create the term with "öffentlicher Dienst", the term is also recognized, but no longer the capitalized variant "Öffentlicher Dienst".

Currently the version 4.1.0 is used in a TYPO3 11 system.

Bildschirmfoto 2023-02-28 um 10 34 06

Bildschirmfoto 2023-02-28 um 10 34 37

featdd commented 1 year ago

Hi @Daniel-Siteway,

thanks for the hint to this issue.

The problem here is that the regex can't differ the character case of the umlauts, even though it is explicitly told to do so. This probably goes down to PHP and character encoding itself handling umlauts like special symbols. (no guarante for this explanation)

Nevertheless I could build a workaround making the case insensitivity work by manipulating the regex a bit.

see: 9a1bd15101ef661379dee02c736d7c7978dfc2ab

Please let me hear your feedback is this worked out for you.

Greetings Daniel

Daniel-Siteway commented 1 year ago

@featdd

thanks for this fix.

Works as expected :)

braukma commented 11 months ago

Hi Daniel, I am facing a similar problem with PHP 7.4, Typo3 11.5.32 and dpn_glossary 4.2.0. Can't use 5.x due to PHP issues with another extension.

My old Site, using Typo3 9.5 and dpn_glossary 3.2.4 works fine.

In My case, Upper case Umlauts are fine (first letter) like "Ökologisch" but any lower case Umlaut within a word like "möglich" ends up like "möglichö". The ö overwites the tailing space.

Tried to use the patch, but failed. Maybe due to my inexperiance in working with git, but maybe it's another issue.

Jürgen

featdd commented 11 months ago

Hi @braukma,

the latest version 5.0.4 still works fine with TYPO3 11.5, did you extend the extension or something else? Unfortionately I can't give you support for problems not related to the extension. (maybe have a look in the TYPO3 slack for general help)

Greetings Daniel

braukma commented 11 months ago

Hi Daniel,

well: Die folgenden Fehler wurden gefunden als versucht wurde, "dpn_glossary" zu installieren:

**Your PHP version is lower than necessary. You need at least PHP version 8.0.0**

I am on PHP 7.4 and unfortunately fail on that requirement. Thus, Version 4.2.0

But havn't tried PHP 8.0 yet. Faced other issues with PHP 8.1 and another extension.

Jürgen

featdd commented 11 months ago

Hi @braukma,

ah okay, unfortunately I'm not planning to do any backwards compatibility. You could still try to apply the patch manually.

Greetings Daniel