search

featdd / dpn_glossary

Glossary extension for TYPO3
http://typo3.org/extensions/repository/view/dpn_glossary
GNU General Public License v2.0
20 stars 29 forks source link

[BUGFIX] Add url_segment to Term Model #206

Closed schloram closed 10 months ago

schloram commented 10 months ago

Hi, I just realized that the url_segment field is missing from the Term Domain Model. Since we need it in our case I figured this might come in handy for others too.

Seems like a little oversight to me.

regards, R

featdd commented 10 months ago

Hi @schloram,

thanks for your pull request, but I can't think of a case where you need this to be loaded in the model. Did you needed that in the TypoScript for the parser?

Greetings Daniel

schloram commented 10 months ago

@featdd Thanks for you quick reply.

Actually I would like to link a glossary term inside a list directly via url. We don't need a detail page and only have a glossary list. To link to a term directly I would like to make use of the urlSegment (or slug) to jump to a specific term via url hash.

For example https://example.com/glossary-list#github jumps directly to the term with the Title "GitHub" (and the resulting urlSegment "github")

featdd commented 10 months ago

Hi @schloram,

thanks, I made a related optimization with #200 using the slug for anchor links by default: ed4bec5049a5261354ed8c808877cf78906d7d7b

Thanks for your pull request.

Greetings Daniel