featdd / dpn_glossary

Glossary extension for TYPO3
http://typo3.org/extensions/repository/view/dpn_glossary
GNU General Public License v2.0
20 stars 30 forks source link

Proposal: No replacement on linked pages #207

Closed PeterProell closed 11 months ago

PeterProell commented 11 months ago

Defining a term and setting the term / link mode everything works out fine.

When the user now clicks on that term somewhere and gets routed to the defined page that explains the term, of course the term is present on that very page as well ... and gets replaced by a link (to the same page) and tooltip.

It would be a great feature to not replace this term on such linked pages.

featdd commented 11 months ago

Hi @PeterProell,

I have implementent this here: 463df030cf088ef329c042f0cbfd9ac0488f0416 The feature is disabled by default, you just habe to enable it.

Do you mind to test this if this also works well for you, before I push a new update to TER? It should recognise t3://page?uid links and "external" urls on the same site. (Some redakteurs don't get this...)

Greetings Daniel

PeterProell commented 11 months ago

First of all: THANK YOU @featdd!!!

Tested it:

featdd commented 11 months ago

Hi @PeterProell,

how does the link look in the term, like "t3://page?uid=123"?

Have you cleared the cache and checked the setting in the TypoScript Object browser?

(It worked on my machine 😅)

Greetings Daniel

PeterProell commented 11 months ago

Link: Yes (and after saving it changes to something like "/Home/Wissen/Management/[349]" Cache and Object Browser: Yes and Yes.

Here's what I found: For existing db entries it doesn't work. If I used the link wizard once more on existent terms and saved them, it works!

featdd commented 11 months ago

@PeterProell What do you mean, like record links?

This currently only works for page links, I either fetch the page uid from the t3://page link or compare directly with the current url.

PeterProell commented 11 months ago

I need to be more precise:

And I figured out why. When I originally created the terms I just entered the page uid in the link field. (234 instead of t3://page?uid=234 ).

What works elsewhere as a power user efficiency hack (just enter the page uid in link fields in the BE without the need to open the link wizard) doesn't work with the new feature.

featdd commented 11 months ago

Hi @PeterProell,

ah okay, now I know what the problem is. Even though this should'nt be done anymore it is still supported to use, so I quickly added this here: 198086d803f115e5e12e42c3bea359b4d7168bf3

You may have a look and tell me if it works 🙂

PeterProell commented 11 months ago

It works :)! Thanks for your dedication!!

featdd commented 11 months ago

Hi @PeterProell,

I just pushed a new Update to TER.