search

feather-rs / feather

A Minecraft server implementation in Rust
Apache License 2.0
2.58k stars 143 forks source link

Download failed for server.jar #473

Closed Seadragon91 closed 2 years ago

Seadragon91 commented 2 years ago

Description

When I build feather I got this error:

error: failed to run custom build command for `feather-datapacks v0.1.0 (/home/lukas/rust/feather/feather/datapacks)`

Caused by:
  process didn't exit successfully: `/home/lukas/rust/feather/target/debug/build/feather-datapacks-1cf8e9c030678bb2/build-script-build` (exit status: 1)
  --- stderr
  Error: please make sure you have an Internet connection.

  Caused by:
      0: failed to download vanilla server JAR
      1: timed out reading response
warning: build failed, waiting for other jobs to finish...
error: build failed

Well my internet works fine. It looks like the function timeout also sets the time limit in which the file has to be downloaded. After changing https://github.com/feather-rs/feather/blob/df3a3a4ae42b0717dd0c50ec3bf3804aed0936c6/feather/datapacks/vanilla_assets/src/lib.rs#L36 the duration to 60, it builds fine. That means the file has to be downloaded in max 10 seconds.

Reproduction Steps

  1. Have a slow internet
  2. Build feather

What You Expected to Happen

Successful build.

Your Environment

Seadragon91 commented 2 years ago

I guess this can be closed?