Iaiao commented 2 years ago

Kick the player if the server is outdated

Status

[x] Ready
[ ] Development
[ ] Hold

Description

Short description what you did and/or fixed

Related issues

Leave empty if none

Checklist

[x] Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
[ ] Removed unnecessary commented out code
[ ] Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

FussballAndy commented 2 years ago

https://github.com/feather-rs/feather/blob/d5748260fbf7fcee79b52604518848b614d382ce/feather/server/src/initial_handler.rs#L48-L50

Maybe the documentation of InitialHandling::Disconnect should be changed with this pr, because it is not just used for failed status pings anymore. Btw sorry for making this mistake of only checking one side of Protocol version in the first place. 😅

HttpRafa commented 1 year ago

The project is dead

feather-rs / feather