feather-rs / feather

A Minecraft server implementation in Rust
Apache License 2.0
2.61k stars 142 forks source link

Change Title's inner value and message type to `Text` #518

Closed Iaiao closed 2 years ago

Iaiao commented 2 years ago

Change Title's inner value and message type to Text

Status

Description

This PR changes Title to use Text instead of json-serialized String and messages to use Text instead of raw String, adds a new quill->host serialization method (json). This change was made because bincode ^1 doesn't support deserialize_any but Text is an untagged enum and requires deserialize_any.

Related issues

Checklist

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.