leElvyn commented 2 years ago

Added data field to the Particle Struct and particles system

Status

[x] Ready
[ ] Development
[ ] Hold

Description

Added field data: f32 to struct struct Particle.
Added that field in send_particle()
Added that field to particle-examples

Related issues

Leave empty if none

Checklist

[x] Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
[x] Removed unnecessary commented out code
[x] Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Iaiao commented 2 years ago

What is particle data? Is it particle speed or what? If so, I think it should be renamed (and also changed on wiki.vg)

oxkitsune commented 2 years ago

it usually means speed, but for some particles it changes other stuff like colour fade speed, size variations etc. particle data is fine in my opinion.

not sure why i didnt include it originally when i did the particle stuff

Iaiao commented 2 years ago

Color transitions, colors, block data and other particle stuff is defined in ParticleKind (https://wiki.vg/Protocol#Particle)

feather-rs / feather