The new implementation should behave identically to the old code, with a couple small optimizations. There is room for more optimization too :) This is the change that I hope someone can fully review
Related issues
Checklist
[x] Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
[x] Removed unnecessary commented out code
[ ] Used specific traces (if you trace actions please specify the cause i.e. the player)
Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.
Status
Description
I have bumped the hecs version to
0.7, and removed the dependency on the git version.This mostly involved small changes to compensate for
Entity::from_bitsbeing fallible now. The biggest change was reimplementing theDynamicQuerylogic (from https://github.com/feather-rs/feather-hecs/commit/87d8d00ac885f9a48b7dd433e245c250cd90737e) in-tree.The new implementation should behave identically to the old code, with a couple small optimizations. There is room for more optimization too :) This is the change that I hope someone can fully review
Related issues
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.