feather-rs / feather

A Minecraft server implementation in Rust
Apache License 2.0
2.61k stars 142 forks source link

Rewrite arg parsing in feather-proxy with argh 0.1 #535

Open Plecra opened 2 years ago

Plecra commented 2 years ago

Status

Description

This PR replaces the clap implementation with an equivalent (minus all clap's goodies :>) argh implementation. This helps prune the dependency tree of a bunch of crates only clap is using, and reuses the argh dependency that is already being used by cargo-quill. (argh also shares dependencies with other crates in the tree like strum-macros and feather-blocks-generator)

Related issues

Leave empty if none

Checklist

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.