feather-rs / feather

A Minecraft server implementation in Rust
Apache License 2.0
2.61k stars 142 forks source link

Allow optionally building without plugin-host #540

Open Plecra opened 2 years ago

Plecra commented 2 years ago

Status

Description

This was fantastic! The implementation was already very cleanly separated so it wasn't any trouble to turn plugin-host off all together. This saves a bunch of compilation time for me 😁

I'm not very well versed in github actions, but I've made an attempt at extending the CI to test both with and without the plugins enabled. Let's see if it works...

Related issues

Leave empty if none

Checklist

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Plecra commented 2 years ago

uhh that's funny. it built just fine on my end