Open boukeversteegh opened 3 years ago
Solves #1041
Merging #1042 (0e637ba) into master (a718a7e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1042 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 34 34
Branches 3 3
=========================================
Hits 34 34
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a718a7e...f07df61. Read the comment docs.
This is an SVG iconset, you're expected to know how svg tags work (IMO).
From my consumer perspective, how the icons are rendered and details of SVG are internals to the product. The product is that I can easily display an icon in an html file, by using only CSS <i class="feather" data-feather="user"/>
.
So I find it strange to be expected to know how SVG tags work, because even if I do know, it also implies that I should know that styling of the original <i>
is transferred to the generated SCG, which is another under-the-hood aspect.
Font-awesome is explicit about how it works, has a documentation page about sizing, and even provides helper classes to scale icons. That's why it's very user friendly and so popular. I hope feather can be as user friendly and popular.
Feather is not really maintained anymore - you may want to come over at @lucide-icons
The word 'size' is not mentioned anywhere in the readme or on the website, giving the impression that changing size is completely impossible.
This low-hanging fruit example could help people find the solution more easily.