feathericons / feather

Simply beautiful open-source icons
https://feathericons.com
MIT License
24.67k stars 1.21k forks source link

Fixed several bugs, code refactoring #1061

Closed toir427 closed 2 months ago

toir427 commented 3 years ago

Fixed test npm run all. Conflict with webpack-cli

node_modules/webpack-cli/bin/config-yargs.js:89
                                describe: optionsSchema.definitions.output.properties.path.description,
                                                                           ^

TypeError: Cannot read property 'properties' of undefined

I fixed with change version webpack-cli@3.1.1.

When I run a jest. It shows the following error.

SecurityError: localStorage is not available for opaque origins

      at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
          at Array.forEach (<anonymous>)

I found a solution and fixed it. This issue helped me fix it

I fixed the problem. if the HTML tag [data-feather] attribute is empty, there is no problem in the console. and I wrote a test for it.

I removed package-lock.json from git cache and added got .gitignore and other config and log files

codecov[bot] commented 3 years ago

Codecov Report

Merging #1061 (9f6c9b4) into master (a718a7e) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1061   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        35    +1     
  Branches         3         4    +1     
=========================================
+ Hits            34        35    +1     
Impacted Files Coverage Δ
src/to-svg.js 100.00% <ø> (ø)
src/replace.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a718a7e...926c282. Read the comment docs.