search

feathericons / feather

Simply beautiful open-source icons
https://feathericons.com
MIT License
24.67k stars 1.21k forks source link

Replace "xlink:href" with "href" #1070

Closed micka-fdz closed 2 years ago

micka-fdz commented 3 years ago

As mentioned in this documentation, xlink:href attribute is now deprecated.

SVG 2 removed the need for the xlink namespace, so instead of xlink:href you should use href.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1070 (448becb) into master (a718a7e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 448becb differs from pull request most recent head d1db98b. Consider uploading reports for the commit d1db98b to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1070   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a718a7e...d1db98b. Read the comment docs.

micka-fdz commented 3 years ago

Hi @colebemis. I don't understand previous Codecov Report. What should I do?