feathericons / feather

Simply beautiful open-source icons

https://feathericons.com

MIT License

24.93k stars 1.22k forks source link

Icon request: windows #91

Open alexantr opened 7 years ago

alexantr commented 7 years ago

Icon name: windows Usage: "Windows" key on keyboard like "command" key, applications builds for Windows. Example: icons8-windows8-64

colebemis commented 7 years ago

Are you thinking this would go in the logos category?

alexantr commented 7 years ago

I think, yes, because it is real logo of Windows.

MorrisJohns commented 5 years ago

I created this icon for Windows 10:

<path d="M3,5 18,3 18,18 3,16Z M3,10.5H18 M10,5V16"></path>

Windows

Probably small enough to not need copyright, but I am happy that it is under MIT and assign copyright to the feathers icons. It is an outline, so not a direct copy of the Windows icon.

moeenio commented 5 years ago

171 @MorrisJohns

jletey commented 5 years ago

@locness3 @colebemis @alexantr @MorrisJohns How does this look?

Screen Shot 2019-07-02 at 7 42 07 AM

MorrisJohns commented 5 years ago

That really reminds me of the Office 2010 logo! I prefer a vertically symmetrical icon, although I admit some Windows 10 logos seem to be non-symmetrical (e.g. the start button is weird).

jletey commented 5 years ago

@MorrisJohns By "vertically symmetrical", what would you exactly like to see ... neither mine nor your icons are vertically symmetrical

MorrisJohns commented 5 years ago

Sorry, I meant horizontally 😊

I think I got the numbers right, and I thought its sizing looked OK when I used devtools to paste it into https://feathericons.com/

From: John Letey notifications@github.com Sent: Tuesday, 2 July 2019 5:15:02 PM To: feathericons/feather Cc: Morris Johns - TimeFiler; Mention Subject: Re: [feathericons/feather] Icon request: windows (#91)

@MorrisJohnshttps://github.com/MorrisJohns By "vertically symmetrical", what would you exactly like to see ... neither mine nor your icons are vertically symmetrical

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/feathericons/feather/issues/91?email_source=notifications&email_token=AAJME5FFGLUM7QZTOFN23HTP5LP5NA5CNFSM4DOJMZTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZACQUY#issuecomment-507521107, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAJME5BIDS2VRZWKUYMLDOTP5LP5NANCNFSM4DOJMZTA.

jletey commented 5 years ago

@MorrisJohns I can make my icon horizontally symmetric if you would like! Given the fact that @locness3 told you to look at the guidelines (https://github.com/feathericons/feather/issues/91#issuecomment-472296090) ... I don't think your icon followed the guidelines. Now I'm not quite sure if my icon satisfies the guidelines ... but I'm pretty sure

MorrisJohns commented 5 years ago

Definitely useful to have a Windows icon added to the set, so happy to see whatever land, as it doesn't affect me. I am not a designer, and as you said, I am not following the guidelines! Cheers

jletey commented 5 years ago

Definitely useful to have a Windows icon added to the set, so happy to see whatever land, as it doesn't affect me. I am not a designer, and as you said, I am not following the guidelines! Cheers

@locness3 Is my icon okay to submit?

moeenio commented 5 years ago

I guess yes !

jletey commented 5 years ago

Wonderful ... opening a PR now!