feathericons / feather

Simply beautiful open-source icons
https://feathericons.com
MIT License
24.85k stars 1.22k forks source link

feat: Add `dice` icon #918

Closed johnletey closed 1 year ago

johnletey commented 4 years ago

This PR is a follow up from #813. @imlinus deleted his forked repo, so there is no way to make any further changes to his PR, which is needed.

Closes #812


https://github.com/feathericons/feather/pull/813#pullrequestreview-420264183

@n1ru4l does this resolve your issue?

codecov[bot] commented 4 years ago

Codecov Report

Merging #918 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b15b4a7...9b24d40. Read the comment docs.

imlinus commented 4 years ago

Thank you for the help with this one. I'm really not a designer and should probably never open Figma again :-D

johnletey commented 4 years ago

I'm really not a designer and should probably never open Figma again :-D

@imlinus We all start from somewhere! I'm far from being a designer! If you want to take my work and open another PR go for it, as it was your icon that I tweaked a bit.