search

feathericons / react-feather

React component for Feather icons
https://npm.im/react-feather
MIT License
1.92k stars 126 forks source link

Update twitter's icon #109

Open akshay-99h opened 10 months ago

akshay-99h commented 10 months ago

I was working on a project that uses react-feather. It still shows the bird logo. Now that the logo of twitter has changed to "X", I think we can update it to X here as well.

milinddhamu commented 10 months ago

src/icons/twitter.js , file directory for reference

imMatheus commented 10 months ago

I don't think it should be changed, the thing is that the "Twitter" logo is still the bird, the platform changed its name to "X" so if you want the new icon it should not be that the Twitter component changes as you very well might want the bird logo. But instead, a new icon should be added for the X logo. The question is what to name it, X is already taken, so if it were to be added maybe something like or something like that.

milinddhamu commented 10 months ago

i updated path to new logo in main file i mentioned above , they are not reviewing it. I opened a PR already.

imMatheus commented 10 months ago

There is a Issue for it already on the main feather repo. I would guess that they are going to add it once it has been added to the main Feather repo first https://github.com/feathericons/feather/issues/1207