search

feathericons / react-feather

React component for Feather icons
https://npm.im/react-feather
MIT License
1.92k stars 126 forks source link

prop-types should not be a peer dep #38

Closed samhh closed 5 years ago

samhh commented 5 years ago

prop-types is listed as a peer dependency, however:

  1. It isn't actually required at runtime as far as I can tell.
  2. Many users (e.g. TypeScript users) won't be using it, so even if I'm wrong on the first point it probably shouldn't be required.
carmelopullara commented 5 years ago

This has been updated in version 2. prop-types is no more a peer dependency.