search

feathericons / react-feather

React component for Feather icons
https://npm.im/react-feather
MIT License
1.92k stars 126 forks source link

Question: Should viewBox contain {size}? #9

Closed goliney closed 6 years ago

goliney commented 6 years ago

I noticed, that size prop is applied to width and height of svg. However, viewBox remains constant. Shouldn't it be updated accordingly?

https://github.com/carmelopullara/react-feather/blob/6948db542e8146a760e433b7496919393b8d306d/src/icons/x.js#L9-L11