search

feathericons / react-feather

React component for Feather icons
https://npm.im/react-feather
MIT License
1.93k stars 126 forks source link

Case Consistency #95

Open Aparaxium opened 3 years ago

Aparaxium commented 3 years ago

Is there a reason GitHub uses PascalCase while Gitlab uses Snakecase?

export { default as GitHub } from './icons/github'; export { default as Gitlab } from './icons/gitlab';

Proposal: Change Gitlab to GitLab

imMatheus commented 1 year ago

I would maybe agree here, I first thought that it could be because GitLab spelled there name "Gitlab", in which case it makes sense to as it is now, but they dont. So this would make change to change. But also a super small thing that might have unnecessary ripple effects through out some peoples project, it is a braking change after all