feathers-plus / cli

FeathersJS CLI supporting both REST and GraphQL architectural concepts and their query languages.
https://generator.feathers-plus.com/
Other
43 stars 7 forks source link

generate hook misssing #7

Closed SassNinja closed 5 years ago

SassNinja commented 6 years ago

If I've understood correctly feathers-plus is supposed to offer the same features as feathers cli (plus additional ones), isn't it?

I tried to generate a hook via

feathers-plus generate hook

but this command doesn't seem to be supported

Has it been forgotten?

eddyystop commented 6 years ago

We decided not to include generate hook. First its not possible to correctly position a call to the hook in serviceName.hooks.?s. That has to be done by manually. Second, adding hooks manually is trivial.

The most we could do is create an empty module for the hook and require it in serviceName.hooks.?s.

SassNinja commented 6 years ago

The most we could do is create an empty module for the hook and require it in serviceName.hooks.?s. - @eddyystop

Then it would be almost the same as feathers cli. It may be trivial but nevertheless I think it's a nice helper, to help not forget the test.

eddyystop commented 6 years ago

I agree. It seems I discounted this too easily. I'll leave this as a to do.

eddyystop commented 5 years ago

Sorry, issues under feathers-plus/cli don't get reviewed much at all. Most issues are created under feathers-plus/generator-feathers-plus.

generate hook was implemented and documented some time ago.