search

feathersjs-ecosystem / authentication-client

[MOVED] The authentication client
https://github.com/feathersjs/feathers
MIT License
41 stars 19 forks source link

Internet Explorer compatibility #97

Closed ghost closed 6 years ago

ghost commented 6 years ago

Module versions: 1.0.2

NodeJS version: 8.11.0

Operating System: Windows 10

Browser Version: Internet Explorer 11

Hi, can you please make it IE compatible?

I get an error for shorthand properties:

let hooks = {
  populateHeader,
  populateAccessToken,
  populateEntity
};
daffl commented 6 years ago

If you use this module directly you have to set up a JavaScript transpiler like Babel.

You can also use the already transpiled and IE11 tested bundle at @feathersjs/client.

winchell commented 6 years ago

~I'm using @feathersjs/client and still getting Expected ':' (at http://localhost:3000/static/js/bundle.js:743:17) in IE11. Any ideas?~

import feathers from '@feathersjs/client';
import rx from 'feathers-reactive/dist/feathers-reactive';
let socketio = feathers.socketio;
let authentication = feathers.authentication;
...

Update: above code works and there is no problem. I had an unrelated caching issue.

daffl commented 6 years ago

What version of feathers-reactive are you using? This issue should be fixed in 0.7.0 or later.

winchell commented 6 years ago

It was user error. Updated my post. Thanks for responding!