search

feathersjs-ecosystem / authentication-jwt

[MOVED] JWT authentication strategy for feathers-authentication using Passport
https://github.com/feathersjs/feathers
MIT License
30 stars 10 forks source link

Remove `typeof 'string'` check for secret #9

Closed jeffijoe closed 7 years ago

jeffijoe commented 7 years ago

A secret can also be a buffer (when passed to jsonwebtoken) and the string check will prevent that.

Offending line: https://github.com/feathersjs/feathers-authentication-jwt/blob/master/src/index.js#L43

daffl commented 7 years ago

Did you try if it works removing this line of code from the code for this package in node_modules?

jeffijoe commented 7 years ago

Yes, it works with that line removed.