search

feathersjs-ecosystem / authentication-local

[MOVED] Local authentication plugin for feathers-authentication
https://github.com/feathersjs/feathers
MIT License
26 stars 15 forks source link

hash-password hook will skip users if they are missing password #58

Closed axmad22 closed 6 years ago

axmad22 commented 6 years ago

When adding this hook to the users service in the before method and I send multiple Created users with some users without passwords, it will remove them from the context and will only save users with password.

Should it not just skip the hashing for users without password instead and then forward All users to the next hook.

daffl commented 6 years ago

You are absolutely right, I don't think there was a reason for this behaviour. Fixed in v1.1.1