search

feathersjs-ecosystem / authentication-oauth2

[MOVED] OAuth 2 plugin for feathers-authentication
https://github.com/feathersjs/feathers
MIT License
26 stars 15 forks source link

Follow failureRedirect on oauth2 authentication failure #11

Closed buske closed 7 years ago

buske commented 7 years ago

This fixes the issue whereby failureRedirect is not followed when the app.authenticate call fails: https://github.com/feathersjs/feathers-authentication/issues/387

ekryski commented 7 years ago

Nice catch man! Looks good.

ekryski commented 7 years ago

@buske any chance you want to do the same PR for https://github.com/feathersjs/feathers-authentication-oauth1? 😁

buske commented 7 years ago

@ekryski will do!

ekryski commented 7 years ago

@buske thanks! Let me know if you can't get to it in the next couple days, otherwise I'll take a stab. 🍻

buske commented 7 years ago

@ekryski Done! The two corresponding oauth1 PRs are here: https://github.com/feathersjs/feathers-authentication-oauth1/pulls. I has mis-referenced oauth2 in a PR title and a commit message, which may have caused confusion, so those are fixed now.