Added support for redirect options on strategy options (#41)

[nsainaney]

Fix for issue #41

[daffl]

Thank you @nsainaney. Should this be called oauth2Settings.redirectOptions or just pass oauth2Settings? It looks like @nabeards expected it to be added at the top level (as properties on oauth2Settings) which I think should be fine as long as it doesn't error (or conflict with other settings).

[nsainaney]

Simplified the options based on feedback from @daffl and @nabeards

[ekryski]

this looks good. Thank you @nsainaney! :shipit:

[nsainaney]

%$^ - I'll fix. Easy enough

@ekryski commented on this pull request.

---

In test/index.test.jshttps://github.com/feathersjs/feathers-authentication-oauth2/pull/42#discussion_r140864756:

@@ -112,6 +112,19 @@ describe('feathers-authentication-oauth2', () => { app.passport.options.restore(); });

• it('registers the refirect options on strategy options', () => {

Should say "redirect". Not a show stopper....

[nsainaney]

Fixed typo in test name

[nsainaney]

Ugh - I believe I've made a mistake. The config is erroneously:

{
auth : {
   github: {
       // clientId etc
      github : {
      // redirect options
     }
  }
}

instead of

{
auth : {
   github: {
       // clientId etc
      // redirect options
  }
}

I didn't realize this until I put it into a real project. Any objections to re-opening and letting me fix this?

My apologies

[daffl]

Yes. Please submit another PR and we'll make a patch release.

[nsainaney]

See PR #44