feathersjs-ecosystem / authentication-oauth2

[MOVED] OAuth 2 plugin for feathers-authentication
https://github.com/feathersjs/feathers
MIT License
26 stars 15 forks source link

Dependency @feathersjs/express not declared #59

Closed vshulev closed 6 years ago

vshulev commented 6 years ago

Steps to reproduce

Expected behavior

The package should declare @feathersjs/express as a dependency or peer dependency.

Actual behavior

Following error is thrown:

Error: Cannot find module '@feathersjs/express/rest'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (****\node_modules\@feathersjs\authentication-oauth2\lib\index.js:4:14)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)

System configuration

Tell us about the applicable parts of your setup.

Dependencies

  "dependencies": {
    "@feathersjs/authentication": "^2.0.1",
    "@feathersjs/authentication-oauth2": "^1.0.1",
    "@feathersjs/configuration": "^1.0.1",
    "@feathersjs/express": "^1.1.2",
    "@feathersjs/feathers": "^3.0.1",
    "passport-google-oauth20": "^1.0.0"
  }

NodeJS version: 8.9.0

Operating System: Windows 10

daffl commented 6 years ago

True indeed. Must've been missed since it will always be a dependency (oauth2 won't work without having the Express wrapper set up).

daffl commented 6 years ago

Released as v1.0.2