Pass a Custom id field for service (serviceId)

[duttonkj]

Summary

• [ ] Tell us about the problem your pull request is solving.

We use a custom id field for our feathers services (_id). The verifier checks for the service id on the user object using the default .id. In our case, it throws an error: debug('failed: the service.id was not set'); Also, patches to the user record fail and the userId is not properly set in the token payload due to the same issue.

This may not best the solution, but we are proposing passing in an serviceId when configuring oauth2:

const oauth2Config = {
    name: 'sampleStrategry',
    Strategy: Strategy,
    clientID: config.clientID,
    clientSecret: config.clientSecret,
    passReqToCallback: true,
    // Pass in our custom service id
    serviceId: '_id'
};

This would default to id when not passed

• [ ] Are there any open issues that are related to this?

Nope.

• [ ] Is this PR dependent on PRs in other repos?

Not at the moment. If this solution is accepted I would open pull request in following packages for related issues:

• @feathersjs/authentication-oauth1
• @feathersjs/authentication/lib/socket

Thanks for all the hard work on feathersjs!

[daffl]

As long as your service has the id property pointing to its id field it should already work.

app.service('mycustomService').id = 'customIdField';

[daffl]

Thank you for the PR! I'm going to close it though since this should already be solvable with what I suggested instead of adding a new configuration option that has to be documented and tested.