search

feathersjs-ecosystem / authentication-oauth2

[MOVED] OAuth 2 plugin for feathers-authentication
https://github.com/feathersjs/feathers
MIT License
26 stars 15 forks source link

DefaultVerifier profile id field not configurable #91

Closed Calavoow closed 6 years ago

Calavoow commented 6 years ago

Steps to reproduce

The DefaultVerifier takes the profile.id field to query if a profile already exists. For my data this field does not exist and should not be used. I tried installing a hook to modify the data to conform to the expected layout, but there does not seem to be a way since I cannot obtain the auth service endpoint when starting the app. (If there is, please tell me)

See https://github.com/feathersjs/authentication-oauth2/blob/4ce4af60e4e04b975e9d93cd5151418d7db256d4/lib/verifier.js#L81

Expected behavior

I expect the id field to be configurable.

Actual behavior

The DefaultVerifier asserts profile.id exists.

System configuration

Tell us about the applicable parts of your setup.

Module versions (especially the part that's not working): feathersjs/authentication-oauth2 v1.2.2

daffl commented 6 years ago

If that field is not available the verifier can be customizes as documented by extending it and implementing the logic you need.

daffl commented 6 years ago

I am going to close this issue since this repository has been moved to https://github.com/feathersjs/feathers. If you have any other questions, feel free to open an issue there.