feathersjs-ecosystem / configuration

[MOVED] A plugin for configuring a Feathers application
https://github.com/feathersjs/feathers
MIT License
28 stars 15 forks source link

PR: Support modules in config #12

Closed wkw closed 8 years ago

wkw commented 8 years ago

We've been throwing a ton of stuff into our FeathersJS install and have outgrown purely static config files. Needed some flexibility and options for computed values so that derived config wasn't pushed up to the app initialization or higher layers.

I took a look at feathers-configuration and since it is using require() to pull in the .json files, there's no reason I can think of not to support both json and node module exports.

I'm going to send over the PR. I don't see anything in these minor mods which breaks existing code; only expands the options. But let me know if I missed some detail.

Short summary of what I remember changing: