search

feathersjs-ecosystem / feathers-authentication-management

Adds sign up verification, forgotten password reset, and other capabilities to local feathers-authentication
https://feathers-a-m.netlify.app/
MIT License
246 stars 98 forks source link

Update to v4 authentication #127

Closed TheSinding closed 4 years ago

TheSinding commented 4 years ago

Summary

This solves the problem with feathers-authentication v4

claustres commented 4 years ago

I am just coming into the module since @eddyystop needed to stop his contribution, it will probably need some time to see how it goes but the idea is to still releasing when necessary.

To merge this one I would need a more detailed explanation of the broad lines: why exactly this PR is required to use the module in v4 as it seems to also work as is ? What are the additional features ?

By the way I've seen https://www.npmjs.com/package/authentication-local-management-v4, which seems to be a release of your fork with some additional features but we don't have any PR for. Are you aware of it ?

Thanks for your feedback

TheSinding commented 4 years ago

Its been 5 months since I looked at it and I'm on vacation right now, can it wait till I get back?

I don't really remember it

claustres commented 4 years ago

Of course this can wait we only try to get on with this module and to keep it up to date, I don't yet have any ETA for a release ;-)

gchokeen commented 4 years ago

Are you going to merge it anytime sooner?

TheSinding commented 4 years ago

So I've taken a look at the pull request again.

It basically just makes the library work with the new hash-password method/hook from the newer feathers/authentication-local library. Specifically this part of the hash-password method.

It just adds the "support" for the new field parameter. Then there is a lot of prettier changes, which should properly be reversed, to make it look like the old code again.

Then I fix the tests.

I don't know why it would work as-is for some people, when I tested it (and use it in production), it broke with v4.

There are no new features in this branch, it just keeps the library as-is, but I wouldn't mind working on it.

claustres commented 4 years ago

OK thanks, just tried to merge by resolving conflicts but CI fails, will need a deeper look.

TheSinding commented 4 years ago

I will take a look later

claustres commented 4 years ago

I've resolve the issue with the lock file locally and pushed to master, thanks very much.

TheSinding commented 4 years ago

You got it, if you need any help, just ask :)