search

feathersjs-ecosystem / feathers-authentication-management

Adds sign up verification, forgotten password reset, and other capabilities to local feathers-authentication
https://feathers-a-m.netlify.app/
MIT License
246 stars 98 forks source link

Update Library Dependencies and Code for Feathers 5 (Dove) #210

Closed pdfowler closed 12 months ago

pdfowler commented 1 year ago

Summary

I'm putting the final touches on our upgrade to Feathers v5 Dove, and keep running into inconsistent builds, with probelms traced back to v4.x feathers-common and feathers-adapter-commons libraries getting referenced from this library. This PR brings feathers-authentication-management in-line with the v5 release.

This PR builds on the branch from @mdartic and ensures that the test suite is passing. I am currently testing an internaly published package based on this branch and will update as needed.

Todo

Other Information

netlify[bot] commented 1 year ago

Deploy Preview for feathers-a-m ready!

Name Link
Latest commit a7a010c3c2be348387afe9a54dfea7ecd0a8817c
Latest deploy log https://app.netlify.com/sites/feathers-a-m/deploys/6485407cb417360008e47a32
Deploy Preview https://deploy-preview-210--feathers-a-m.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ymarcon commented 12 months ago

Anyone to review this PR?

claustres commented 12 months ago

As far as I can see I don't see any breaking changes or doubtful refactoring and tests are passing, good job. However, as I am less familiar with latest typescript version I suggest @fratzinger to review it as well.

fratzinger commented 12 months ago

I'll merge and do some chore work like updating dependencies right now. I'll release a major version afterwards. Thank you all for your work and sorry for the delay! ❤️