search

feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

Added tests for S3 blob store #38

Closed claustres closed 6 years ago

claustres commented 6 years ago

This ensure the module works well with https://github.com/jb55/s3-blob-store, eg to avoid issues like https://github.com/feathersjs-ecosystem/feathers-blob/issues/37.

You need to have the following environment variables defined to make it work:

daffl commented 6 years ago

Can we make them pass on CI? The error is

Error: S3BlobStore bucket option required

claustres commented 6 years ago

As mentioned in my comment you need to define some env variables, because some should be kept secret I did not set it in code/config directly. Don't know how you used to manage things like that but the best should be to create a S3 account specifically dedicated to Feathers on AWS so that the members of the team have access.

daffl commented 6 years ago

A sorry, missed that when I looked at it again. I just invited you to collaborate as an admin which should allow you to add secret environment variables to the Travis build settings if you would like to provide the info for now.

claustres commented 6 years ago

Synced my account and it seems OK. With respect to AWS do I use my account to create a new user in order to get the keys or do you already have a common account for the Feathers team so that you could generate one ?

claustres commented 6 years ago

I've created a AWS user + S3 bucket, tests are passing on my laptop but not on travis, can't still figure out why. I believed it was linked to a / in the secret key that needed to be escaped but does not seem to be that...

daffl commented 6 years ago

Do you want to send me a private message with the keys? Then I can give it a quick try, too.

claustres commented 6 years ago

Done through slack, let me know.