search

feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

Implemented custom id field on remove #40

Closed claustres closed 6 years ago

claustres commented 6 years ago

Fix for https://github.com/feathersjs-ecosystem/feathers-blob/issues/39

daffl commented 6 years ago

This makes sense but removing the extend function makes it a (probably unnecessary) breaking change.

claustres commented 6 years ago

I could add it back, I actually did not see where it is used in the code so I believed it was a typo but I probably missed the point.

daffl commented 6 years ago

It was part of an old service extension API. It's probably fine to remove but would be a breaking change since somebody could still be using it.

claustres commented 6 years ago

Change reverted.

daffl commented 6 years ago

Thank you. Released as v1.4.1