feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

feat: add typescript typings with dtslint tests #79

Closed Mairu closed 4 years ago

Mairu commented 4 years ago

Summary

Add Typescript types to the repo. Also added dtslint (as dev dependency) with some tests.

Other Information

In the readme, there are described 4 options for initializing the service. But in the code only 3 are consumed, so I added only these 3 to the types. returnUri is only set by the returnBuffer option -> https://github.com/feathersjs-ecosystem/feathers-blob/blob/master/lib/index.js#L31 So either the readme should be changed, or the option should be consumed.

I can update the readme if wanted. (Also the copyright date could be updated)

Closes #77 #78

claustres commented 4 years ago

Great thanks