feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

Fix option returnUri to have false value #82

Closed belal-mazlom closed 3 years ago

belal-mazlom commented 3 years ago

This makes returnUri option could have false value to have output to be without uri property

Issue related:

75

claustres commented 3 years ago

Thanks for this, after a first quick review it seems OK to me. However, would you mind updating the docs to clarify the usage? Thanks

belal-mazlom commented 3 years ago

Thanks @claustres for quick response.

It's match with the current docs in README.md

blobService = BlobService(options)

claustres commented 3 years ago

Maybe I am wrong but at least this should be updated/removed doesn't it?

Tip: returnUri/returnBuffer are mutually exclusive. If you need both extract the buffer from the data URI on the client-side to avoid transferring the data twice over the wire.

belal-mazlom commented 3 years ago

@claustres I updated README.md file, hope it's better now.

mdartic commented 3 years ago

@claustres could you publish a new version of this package on npm ?

I would like to use this patch, but for the moment, I make my package.json point to the github repo.

Thanks

claustres commented 3 years ago

Released as v2.4