search

feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

Move CI to GitHub action #84

Closed daffl closed 3 years ago

daffl commented 3 years ago

We are using this instead of Travis which seem to be winding down their open source support.

claustres commented 3 years ago

Good work. The travis build was using some encrypted env vars in order to set up access for some tests relying on AWS S3. I am not familiar with GitHub actions but will try to have a look at how to do it. Really strange that the build is considered green because these tests should not work.

daffl commented 3 years ago

Ah sorry I forgot about that. Looks like the tests are skipped when the environment variable doesn't exist (https://github.com/feathersjs-ecosystem/feathers-blob/runs/2363679889?check_suite_focus=true#step:5:32)