search

feathersjs-ecosystem / feathers-blob

Feathers service for blob storage, like S3.
http://feathersjs.com
MIT License
92 stars 32 forks source link

Add abstract-blob-store as a dependency #92

Open clintonb opened 2 years ago

clintonb commented 2 years ago

See #81. If abstract-blob-store is needed to compile the project, abstract-blob-store should be a production dependency. It's currently a development dependency, so not installed when used in other projects.

claustres commented 2 years ago

I am not a typescript expert but as far as I can see a dependence has been added in the types definition. However, from the JS code perspective this dependency is only used in tests (so as a dev dependency). @daffl probably knows how to fix this.

daffl commented 2 years ago

I'd say that everything that is required in the production types file should be a production dependency. An alternative (since abstract-blob-store is really just a test harness) would be to add the Abstract Blob store types from https://github.com/maxogden/abstract-blob-store/blob/master/index.d.ts directly in the typings file here.

claustres commented 2 years ago

I agree, I am not a typescript fan but IMHO using it implies that we should depend on the interface so that if it is changed it will break at compilation time.

daffl commented 2 years ago

Moving abstract-blob-store from devDependencies into dependencies should do it then.