search

feathersjs-ecosystem / feathers-knex

Service adapters for KnexJS a query builder for PostgreSQL, MySQL, MariaDB, Oracle and SQLite3
MIT License
112 stars 59 forks source link

Should other adapters rely on this or Sequelize? #14

Closed daffl closed 8 years ago

daffl commented 8 years ago

I just had another look at Sequelize and it looks a lot like our service interface and support things like $in, $gt etc out of the box already. I am wondering if the other *SQL adapters (feathers-mysql, feathers-pg and feathers-sqlite) should use that instead?

ekryski commented 8 years ago

Hmmm. I dunno. This is starting to feel like the difference between feathers-mongodb and feathers-mongoose. Sequalize allows you to define models and schemas and stuff (which probably makes more sense for a relational db). I'm open to supporting both as long as it isn't too much work.

daffl commented 8 years ago

I think we can totally support both. The main question is what the official adapters should use. Currently I'm leaning towards Sequelize mainly because of the higher adoption and it lines up better with our service concept.

ekryski commented 8 years ago

ok let's get the first cut of these other db adapters out then we can revisit sequelize for the 2.0 release possibly.

daffl commented 8 years ago

Closing this since we'll do it ORM instead of Database specific.