search

feathersjs-ecosystem / feathers-localstorage

A client side service based on feathers-memory that persists to LocalStorage
MIT License
38 stars 15 forks source link

readme links to the wrong version of example #53

Closed FossPrime closed 7 years ago

FossPrime commented 7 years ago

Looks like messages was replaced with a todo.

daffl commented 7 years ago

I'm not following. The Readme does show how to create a /messages service no (https://github.com/feathersjs/feathers-localstorage/blame/master/README.md#L53)?

FossPrime commented 7 years ago

I don't follow either. It seems like the whole point of this is to run this in the browser not the server. To make that happen Id need to boot strap a package loader... hum

"You can run this example with npm start from the cloned repository and going to localhost:3030/messages. You will see the test Message that we created at the end of that file."

Cloning this repository and running npm start will run the todo thing...

daffl commented 7 years ago

You can still use it in Node if you give it a fake localstorage (which is what var storage = require('localstorage-memory') is doing). Cloning the repository will run a todo but the Readme shows a messages example.

FossPrime commented 7 years ago

meh.

daffl commented 7 years ago

A PR that uses example/app.js in the Readme (instead of creating a messages service) would be nice though 😄

FossPrime commented 7 years ago

app.js is really boring... messages is slightly funner. If it were up to me I would spruce the example up with a hint of craziness... people using this are probably far down the rabbit hole