search

feathersjs-ecosystem / feathers-localstorage

A client side service based on feathers-memory that persists to LocalStorage
MIT License
38 stars 15 forks source link

Use with create-react-app #66

Closed saiichihashimoto closed 6 years ago

saiichihashimoto commented 6 years ago

Steps to reproduce

Using create-react-app with this module breaks the build.

I'm using @feathers/client rather than @feathers/feathers and, when I exclude this module, everything builds. With it, the build breaks.

Expected behavior

The create-react-app build should not break.

Actual behavior

It does break. :-P

image

It seems to have the same error as using @feathers/feathers does, ie something in @feathers/commons.

daffl commented 6 years ago

With create-react-app, use the ES5 build from feathers-localstorage/dist/feathers-localstorage instead.

saiichihashimoto commented 6 years ago

image

image

Doesn't really change much...

daffl commented 6 years ago

Well shoot, looks like some ES6 modules slipped through the transpilation step. Give it another go with the latest version 2.0.2