Should use underscores to donate filter params vs. params that are on a model

feathersjs-ecosystem / feathers-mongoose

Easily create a Mongoose Service for Feathersjs.

MIT License

189 stars 96 forks source link

Should use underscores to donate filter params vs. params that are on a model #17

Closed ekryski closed 9 years ago

marshallswain commented 9 years ago

Why not just use $ ? It would be nice to "standardize" how this should work across services. I'll be making a MySQL service sometime and think it would be nice to have similarities in the query/filter params. Other than doing MySQL-specific operations like maybe $join, it would be nice for the API to match as much as possible. I used $ in feathers-mongoose-advanced just to match what MongoDB is already using.

ekryski commented 9 years ago

Agreed. $ it is. PR is coming that will close this and make it consistent between all adapters.

daffl commented 9 years ago

:+1: