Add optional parameter modifierFiltersResults for disabling count of $modify query results

feathersjs-ecosystem / feathers-objection

Feathers database adapter for Objection.js, an ORM based on KnexJS SQL query builder for Postgres, Redshift, MSSQL, MySQL, MariaDB, SQLite3, and Oracle. Forked from feathers-knex.

MIT License

98 stars 48 forks source link

Add optional parameter modifierFiltersResults for disabling count of $modify query results #136

Closed alex-all3dp closed 3 years ago

alex-all3dp commented 3 years ago

Adds an optional parameter for allowing find() queries to opt-out of applying the result of any modifiers to the returned total. Works around the issue with the total of groupBy described in https://github.com/feathersjs-ecosystem/feathers-objection/issues/102 The parameter can be safely set to false for any query with a modifier which does not filter the result set but only enhances it with additional data, e.h. withGraphFetched.

dekelev commented 3 years ago

Released with v7.1.0

alex-all3dp commented 3 years ago

Awesome, thank you! :)