search

feathersjs-ecosystem / feathers-permissions

Simple role and service method permissions for Feathers
MIT License
184 stars 29 forks source link

Role types #64

Closed mkovel closed 4 years ago

mkovel commented 4 years ago

Summary

- [ ] Tell us about the problem your pull request is solving. I am using TS in my project and faced with problem according type of field roles. In manual said that roles can be function that takes the hook context and returns a list of roles, but in types this point is missed .

- [ ] Are there any open issues that are related to this? no - [ ] Is this PR dependent on PRs in other repos? no

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull request, mention that information here. This could include benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.

Thanks for contributing to Feathers! :heart:

mkovel commented 4 years ago

@daffl I added changes that you meant.

daffl commented 4 years ago

Thank you! Publishes as v2.0.2