feathersjs-ecosystem / feathers-reactive

Reactive API extensions for Feathers services
MIT License
216 stars 37 forks source link

get calls ignore params when being cached #146

Open homj opened 5 years ago

homj commented 5 years ago

Steps to reproduce

As described in #92, the internal caching is flawed, even when using listStrategy: 'always'. Additionally to the issue with find, this also affects get calls:

The hash value used to cache responses is based solely on the id and ignores params. This leads to problems, when using client side params to e.g. populate different fields on get calls.

Expected behavior

get calls with different params should result in actual new calls to the backend

Actual behavior

get calls with different params return a cached response when an existing call for the same id exists

System configuration

Backend uses params on get requests to populate different fields

Module versions (especially the part that's not working): feathers-reactive 0.7.2

NodeJS version: 10.10.0

Operating System: macOS 10.13.5

Browser Version: Google Chrome 71.0.3578.98

React Native Version: x (using Angular 7.0.0)

Module Loader: