search

feathersjs-ecosystem / feathers-reactive

Reactive API extensions for Feathers services
MIT License
216 stars 37 forks source link

Failure to import in v0.10 #203

Closed fusillijerry89 closed 1 year ago

fusillijerry89 commented 1 year ago

v0.10 cannot be imported using import statement.

Please fix

RobMaple commented 1 year ago

I've just run into this error. In my case it's specifcally when building for production using vite (therefore rollup). In dev mode its fine. The error seems to be related to the import of the "getParamsPosition" in feathers-reactive/src/resource.js.

I'm not 100% sure but I'm guessing its to do with the mixing of ES imports / cjs exports.

edit: didn't realise there was a PR already

bitflower commented 1 year ago

@RobMaple See my comment here: https://github.com/feathersjs-ecosystem/feathers-reactive/issues/193#issuecomment-1546395700

daffl commented 1 year ago

Should be fixed now in v0.11.0 via https://github.com/feathersjs-ecosystem/feathers-reactive/pull/211